From 65efa8d42315f3cf983e8c54717812070415adb7 Mon Sep 17 00:00:00 2001
From: "J. Hinchliffe" <jjh413@student.bham.ac.uk>
Date: Tue, 24 Jun 2025 22:15:51 +0100
Subject: [PATCH] misc: fix some clippy errors

---
 common/src/elf.rs                             | 2 +-
 emulator/src/emulator/misc/rpc.rs             | 8 ++++----
 emulator/src/emulator/system/emulator.rs      | 1 +
 emulator/src/emulator/system/processor/mod.rs | 1 +
 4 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/common/src/elf.rs b/common/src/elf.rs
index 19607d5..8ef3643 100644
--- a/common/src/elf.rs
+++ b/common/src/elf.rs
@@ -4,5 +4,5 @@ use object::{Endianness, build::elf::Builder};
 
 #[allow(clippy::missing_const_for_fn)]
 pub fn write() {
-    let builder = Builder::new(Endianness::Little, false);
+    let _builder = Builder::new(Endianness::Little, false);
 }
diff --git a/emulator/src/emulator/misc/rpc.rs b/emulator/src/emulator/misc/rpc.rs
index 3ef47e3..737502d 100644
--- a/emulator/src/emulator/misc/rpc.rs
+++ b/emulator/src/emulator/misc/rpc.rs
@@ -180,10 +180,10 @@ impl Drop for RpcClient {
     fn drop(&mut self) {
         self.stop();
 
-        if let Some(handle) = self.thread_handle.take() {
-            if let Some(handle) = Arc::into_inner(handle) {
-                let _ = handle.join();
-            }
+        if let Some(handle) = self.thread_handle.take()
+            && let Some(handle) = Arc::into_inner(handle)
+        {
+            let _ = handle.join();
         }
     }
 }
diff --git a/emulator/src/emulator/system/emulator.rs b/emulator/src/emulator/system/emulator.rs
index fec2a9a..295646e 100644
--- a/emulator/src/emulator/system/emulator.rs
+++ b/emulator/src/emulator/system/emulator.rs
@@ -110,6 +110,7 @@ pub fn run_emulator(
                             );
                         });
                 }
+                #[expect(unused_assignments)]
                 Command::Interrupt(_interrupt) => {
                     update = true;
 
diff --git a/emulator/src/emulator/system/processor/mod.rs b/emulator/src/emulator/system/processor/mod.rs
index 3e9a37a..c81c38e 100644
--- a/emulator/src/emulator/system/processor/mod.rs
+++ b/emulator/src/emulator/system/processor/mod.rs
@@ -19,6 +19,7 @@ pub struct Processor {
     pub dustbin: u32,
 }
 
+#[expect(dead_code)]
 fn log(message: &str) {
     println!("\x1b[32mINFO:\x1b[0m {message}");
 }